Migrate to Middleman 4, CocoaPods 1.11.0.beta.2 and GH actions. #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
approved these changes
Jan 12, 2021
|
can definitely boot up the server now by using this branch. I do get an error though for 'not finding partial file' |
|
would love to finish this so we can get guides updated to 1.10.x releases! |
|
taking over and trying to land this. |
dnkoutso
force-pushed
the
segiddins/middleman-4
branch
4 times, most recently
from
084ab39
to
7f147c2
Compare
dnkoutso
changed the title
dnkoutso
force-pushed
the
segiddins/middleman-4
branch
from
7f147c2
to
ce916c6
Compare
dnkoutso
force-pushed
the
segiddins/middleman-4
branch
2 times, most recently
from
f766c4f
to
750ffde
Compare
dnkoutso
force-pushed
the
segiddins/middleman-4
branch
from
750ffde
to
7d3b4f7
Compare
dnkoutso
reviewed
Aug 12, 2021
| @@ -0,0 +1 @@ | |||
| ../shared | |||
There was a problem hiding this comment.
This is a symlink to ../shared submodule and it helps Middleman 4 load partials from it instead of us copying it over.
dnkoutso
reviewed
Aug 12, 2021
dnkoutso
force-pushed
the
segiddins/middleman-4
branch
from
7d3b4f7
to
26954a1
Compare
|
lgtm! thanks for picking this up, dimitris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to unblock compatibility with the most recent cocoapods releases, which use activesupport 5