Adds a slack notification when a dispute is resolved #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orta
commented
Jan 12, 2017
| @disputes.first.reload.message.should == 'HELLO' | ||
| end | ||
|
|
||
| it 'sends slack notification for a dispute' do |
There was a problem hiding this comment.
couldn't think of a way to verify that the slack message was triggered, we didn't have them for the other one either
There was a problem hiding this comment.
then this test name is misleading
|
LGTM. |
segiddins
reviewed
Jan 12, 2017
|
|
||
| module Pod | ||
| module TrunkApp | ||
| class SlackController |
There was a problem hiding this comment.
make this a module instead of a class since its never instantiated
orta
force-pushed
the
notify_on_resolve
branch
from
034d2c0
to
753cda6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes social issues, it's hard to know if a dispute has been resolved from just our chat room. If I go away for a while no-one really knows if I'm not doing the disputes so they just kinda get abandoned till I remember. Now people can see that nothing has happened.