Random image from bundle displayed (or crash) when img has no src #221

Closed
thillerson opened this Issue Sep 15, 2012 · 5 comments

Projects

None yet

2 participants

@thillerson

If an img tag has no src (src == nil), DTTextAttachment doesn't keep track of that, and tries to find a local image from the bundle, since the scheme is not "data" c.f. DTTextAttachment.m line 112:

NSString *path = [[NSBundle mainBundle] pathForResource:src ofType:nil];

It finds whatever it can find in the bundle, which may be an image, in which case the behavior is strange, or may not be an image, in which case it may crash the app. I experienced a crash when trying to set a nil into the cache.

@thillerson

Sorry, I didn't realize this would create another issue...

@odrobnik

@thillerson what "another issue" are you talking about?

@odrobnik odrobnik closed this Sep 17, 2012
@thillerson

I meant I didn't realize the pull request would create an issue in Github issues...

@odrobnik

each pull request IS an issue. The pull request gets closed by merging it. The original issue needs to be closed either manually or by adding "fixes #221" in the commit message.

@thillerson

Right, I learned that after issuing the pull request. Sorry about that - won't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment