Resolves issue #195, justification of the final line of paragraphs. #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justify is still justifying the last line of some paragraphs, despite pull request Cocoanetics#180/ issue Cocoanetics#179. There are two bugs. First, the calculation of isAtEndOfParagraph on line 172 of DTCoreTextLayoutFrame.m is wrong, checking to see if the line starts at the end of the paragraph. Second, a br doesn't end the paragraph but should suppress justification as if it was the end of the paragraph. Both issues are solved with this change.
odrobnik
added a commit
that referenced
this pull request
Jun 28, 2012
Resolves issue #195, justification of the final line of paragraphs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justify is still justifying the last line of some paragraphs, despite
pull request #180/ issue #179.
There are two bugs. First, the calculation of isAtEndOfParagraph on
line 172 of DTCoreTextLayoutFrame.m is wrong, checking to see if the
line starts at the end of the paragraph. Second, a br doesn't end the
paragraph but should suppress justification as if it was the end of the
paragraph.
Both issues are solved with this change.