Only scan list-tyle-image css value if it is a string #988
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases--the only one I have found so far is inline svg urls--the value for a list-tyle-image is actually an array (it gets split on commas). Previously, parsing the list style would crash. Now we only parse it if it is a string. For reference, here is the line that caused the crash: ```css list-style-image: = url(data:image/svg+xml,%3C%3Fxml%20version%3D%221.0%22%20encoding%3D%22UTF=-8%22%3F%3E%0A%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%=20version%3D%221.1%22%20width%3D%225%22%20height%3D%2213%22%3E%0A%3Ccircle=%20cx%3D%222.5%22%20cy%3D%229.5%22%20r%3D%222.5%22%20fill%3D%22%2300528c%2=2%2F%3E%0A%3C%2Fsvg%3E%0A); ```
|
This doesn't handle the array though, right? |
|
Correct. In the case I ran into handling the array wasn't actually meaningful. I suppose the values could have been joined and then parsed instead of ignored. I'll give that a try. |
|
@ianyh So will there be an addition to this pull request for handing an array, or should we merge this as is? |
|
I couldn't really figure out a way to make it general, so this can probably just get merged as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases--the only one I have found so far is inline svg urls--the value for a list-tyle-image is actually an array (it gets split on commas). Previously, parsing the list style would crash. Now we only parse it if it is a string. For reference, here is the line that caused the crash: