Add -utf8 output option #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tree .strings files in UTF-8, which is much easier to manage. (Modern Xcode will copy your .strings files into UTF-16 into the binary anyhow, so no need to store them as UTF-16.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had written a blog post about how troublesome it is to handle UTF-16 .strings files in my source tree. I've decided to store my strings files as UTF-8 to eliminate confusion with endian issues, and also so that these files can actually be diff'd in GitHub rather than appearing as binary blobs.
The final remaining step has been to somehow override genstrings' propensity to output in UTF-16. That means that I'd have to follow up with a conversion to UTF-8 so that my generated strings files (which I store in my source tree) don't get changed into UTF-16.
I've added UTF-8 output as an option to the demo "genstrings2" here, to make that step easier. Maybe others will find it useful as well. Yes, this extends the abilities of genstrings. Hopefully that is OK.