Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P10 Added judging critera page #66

Conversation

andrewdempsey2018
Copy link
Contributor

Added basic "Judging Criteria" page with some placeholder text. Setup urls, view and navbar link to access the page.

Copy link
Member

@stefdworschak stefdworschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewdempsey2018 this is a really good first pull request you can be proud of! Just a few minor changes that I would recommend. Once you made the changes, just tag me or Tim in the Pull Request again and we can approve it. For future use I would also recommend to flesh out the Pull Request message a little bit (e.g. add areas such as Description, Tests, Errors, Screenshots, etc.); we will also add a template shortly as well.

.env_sample Show resolved Hide resolved
home/templates/home/criteria.html Outdated Show resolved Hide resolved
home/templates/home/criteria.html Outdated Show resolved Hide resolved
home/templates/home/criteria.html Outdated Show resolved Hide resolved
home/templates/home/criteria.html Outdated Show resolved Hide resolved
home/views.py Outdated Show resolved Hide resolved
@andrewdempsey2018
Copy link
Contributor Author

@stefdworschak @TravelTimN

User Story ID: #P10

Description of PR:
Added a basic Judging Criteria page with dummy information in lieu of a final writeup of criteria. Page contains four locations of information with headings on a 2x2 grid & is responsive for small screens. Home/urls.py reflects the new page as well as home/views.py

Tests:

  • Page has been tested on desktop browsers Firefox and Chrome. It has also been tested on an emulated smartphone.

Screenshots:

Desktop Firefox test:

image

Desktop Chrome test:

image

Emulated smartphone test:

image

Know bugs/errors:

  • Page needs actual content so actual judging critera needs to be written up.

Post review/additional changes:

  • reinstated .env_sample after deleting it accidentally
  • rewrote some tags with lower case to keep HTML code style consistent
  • updated home>views.py to be in line with PEP8 standard
  • added new line at the end of criteria.html

@TravelTimN TravelTimN linked an issue Oct 18, 2020 that may be closed by this pull request
Copy link
Member

@stefdworschak stefdworschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just FYI - not sure if you are aware, but you can edit the PR message body. Also, usually if somebody leaves comments, you would use the Reply option for each comment and Resolve the conversation once the comment is addressed. Not a biggie though.

Copy link
Collaborator

@TravelTimN TravelTimN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - might get @stefdworschak to just check from his end.
Also - there might be some issues, since @JimLynx was working on the footer, and the view/url for this was different.
I do like @andrewdempsey2018 namespace better though, short and sweet.

.env_sample Show resolved Hide resolved
@TravelTimN
Copy link
Collaborator

Actually, @andrewdempsey2018 - can you have a look at #74 and adjust the urls/views accordingly to match that of @JimLynx please?
judging_criteria instead of just criteria, as this could eventually be expanded and have a different meaning for something else later. Thanks!

@andrewdempsey2018
Copy link
Contributor Author

andrewdempsey2018 commented Oct 19, 2020

judging_criteria @TravelTimN urls/views updated to match those of @JimLynx

image

@andrewdempsey2018
Copy link
Contributor Author

LGTM

Just FYI - not sure if you are aware, but you can edit the PR message body. Also, usually if somebody leaves comments, you would use the Reply option for each comment and Resolve the conversation once the comment is addressed. Not a biggie though.

Noted, thanks for the tip.

Copy link
Member

@stefdworschak stefdworschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefdworschak stefdworschak merged commit 919ceb8 into Code-Institute-Community:master Oct 19, 2020
@stefdworschak stefdworschak added the hacktoberfest-accepted Accepted PR during Hacktoberfest label Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted PR during Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#P10. As Participant, I would like to see the Judging criteria.
3 participants