-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks class properties of XmlHTTPRequest #261
Comments
Would that be the cause of I had some problems with it... |
Yes, the extension strategy breaks that too. |
I'm not sure this is the same issue, but I was working on a XMLHttpRequest methods reload and found that prototype is broken This may lead to incompatibility with custom code or other plugins, which rewrites the XMLHttpRequest prototype. This can be fixed by adding: On the OpenToke custom service mentioned that this issue can be fixed by adding |
Is this fixed yet ? |
bump |
Really bad issue, this breaks all sorts of scripts in subtle and frustrating ways. |
The use of this library hangs implementation based on XMLHttpRequests . |
Bump. It really conflicts with Symfony toolbar. No AJAX calls in the web profiler. |
Thanks @ecolotko In case of using the version: pace.min.js, you only have to search for the statement: :a[d]=b.prototype[d]:void 0)}catch(f){c=f} Replace by: :a[d]=b.prototype[d]:void 0)}catch(f){c=f}a.prototype = Object.getPrototypeOf(new b); For those still working with bower, I suggest copying: pace.min.js (modified) and copying to an external route, and use: override. Example: Pace
"Main": [
"../../content/scripts/custom/pace.min.js",
]
} Best regards. |
Thanks @1antares1 Update for version 1.0.2, search for: Fixed the conflict with Symfony Profiler. |
Any reason why this wasn't fixed so far? Do you need a pull request? |
I think I tracked this down to the |
fix issue #261 by localizing key per loop in extendNative
CookiePro was also affected by this, which #504 successfully fixed. Good job! Maybe a new publish to NPM could be considered, since many use it from there to this day and the versions up there are very outdated. |
When this library extends XMLHttpRequest here:
https://github.com/HubSpot/pace/blob/b202561ac0d5721a5df8d48dbf94f237c3d44405/pace.coffee#L343-L348
It doesn't bring along the properties of the XMLHttpRequest object itself. For example,
XMLHttpRequest.DONE
is supposed to be a constant, but after extension it's not.The text was updated successfully, but these errors were encountered: