-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflicts with zone.js? #399
Comments
In the newest version of zone.js (0.8.12) using pace with it causes all XMLHttpRequests to fail with the error message:
Please see my issue for more information. If I get time I'll try and fix the issue inside pace itself but I've already spent the good part of 3-4 hours trying to debug this issue so we'll see.. |
@MattJeanes, The reason is it seems in https://github.com/HubSpot/pace/blob/master/pace.js#L351, |
@JiaLiPassion sorry for late reply but yeah turns out my tslinting decided to move the import order around so zone loaded after pace, a bit frustrating but all sorted! |
Hi,
I'm not sure what is going on in pace, but in zone.js there is a function canPatchViaPropertyDescriptor, which basically does the same as the following test-snippet for the console:
When using
pace-progress@1.0.2
, following require changes the output fromtrue
tofalse
.I am not 100% sure that it is a really a pace problem, since I am using webpack where I had to add the
imports-loaderr@0.7.1
specifically for pace:Anyway, I'll just remove pace from my project for now due to this issue combined with the added complexity of my webpack config. But maybe if someone is interested, you could check if you have the same problem without webpacks import-loader and if so forward the issue to the imports-loader repo.
All the best, Robin
The text was updated successfully, but these errors were encountered: