Add e2e test #16
Add e2e test #16
Conversation
test/e2e_test.sh
Outdated
| --forward "http://127.0.0.1:$SERVER_PORT" 2>&1 | tag "[SERVER]" & | ||
|
|
||
| function finish { | ||
| kill $(jobs -p) || true |
There was a problem hiding this comment.
Processes may die between jobs and kill. kill will complain that 'there is no such process', and because of set -e, the script halts its execution there. Should I set +e on the exit trap?
There was a problem hiding this comment.
I'm confused about the behavior of set -e. Doesn't it make e2e_test.sh stop when jobs exits with non-zero?
There was a problem hiding this comment.
Yes it does. set -e turns on the behavior, and set +e turns off it.
There was a problem hiding this comment.
Well, if it does, why do you need || true? The script will terminate when jobs exit with a non-zero value.
There was a problem hiding this comment.
I wanted to make sure wait is called. It waits for remaining child processes to clean up and reports whether they are terminated properly.
foriequal0
force-pushed
the
feature/testcase
branch
2 times, most recently
from
f389fb2
to
9f0ee62
Compare
foriequal0
force-pushed
the
feature/testcase
branch
from
9f0ee62
to
f149bfa
Compare
Test fails, but it's a problem that needs to be addressed in other PRs.