fix: git branches dropdown #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FezVrasta
force-pushed
the
fix/git-branches-dropdown
branch
from
279ccc3
to
6d3e080
Compare
FezVrasta
force-pushed
the
fix/git-branches-dropdown
branch
from
6d3e080
to
1b0b129
Compare
austincondiff
requested review from
austincondiff,
0xWDG,
EstebanBorai and
thecoolwinter
0xWDG
approved these changes
Jan 22, 2024
thecoolwinter
approved these changes
Jan 22, 2024
|
@allcontributors please add @FezVrasta for code |
|
I've put up a pull request to add @FezVrasta! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This addresses the Git branch selector bug described by #1568, the dropdown now uses the Menu component. This also allows for the menu to be navigated and by keyboard
Related Issues
Checklist
Screenshots