feat: git branches nesting

[FezVrasta]

Description

Implements Git branches grouping using the first slash as prefix separator. This allows for easier navigation on large repositories that prefix branches (for example: feat/some-feature)

This PR builds on top of #1570

Related Issues

• ✨ Git branches selector quality of life improvements #1569

Checklist

• I read and understood the contributing guide as well as the code of conduct
• The issues this PR addresses are related to each other
• My changes generate no new warnings
• My code builds and runs on my machine
• My changes are all related to the related issue above
• I documented my code

Screenshots

[austincondiff]

Looks good to me!

Edit: See next review

[austincondiff]

Please fix the SwiftLine errors before we can merge.

[Angelk90]

@FezVrasta : Can you take a screenshot of what appears when you go to the website?

[FezVrasta]

What do you mean? What website?

[Angelk90]

@FezVrasta : If you look at the screenshot you posted it says website and a side menu should open.

[austincondiff]

@Angelk90 I think @FezVrasta has provided sufficient details for this PR.

[Angelk90]

@austincondiff : See where it says docs, the menu on the right opens and the word docs/ggc-sponsor appears, the repetition of the word docs in that case seems useless to me, yes since I'm on docs, I wanted to see if it also happened in the other cases.

[activcoding]

@FezVrasta thanks for the PR! Got some questions:

1: Can we use the popover? I really like its style:

2. How about more symbols for branches and a coloured checkmark for the current branch?

3. Any chance to add more details to each branch section?

[FezVrasta]

I fixed the linter and also removed the branch prefix from the nested dropdown entries. I also added icons to each entry to easily distinguish folders and branches.

[Angelk90]

@FezVrasta: Great, what happens if there is only one branch and it is the selected one.

In the future I would propose to change the branch icon, I would propose like that of xcode.

[FezVrasta]

@FezVrasta: Great, what happens if there is only one branch and it is the selected one.

In the future I would propose to change the branch icon, I would propose like that of xcode.

I haven't changed that behavior so it will work like it does today.

[austincondiff]

This looks fantastic @FezVrasta! I would agree, we have a "branch" symbol in CodeEditSymbols that you might use instead.

[FezVrasta]

Done

[austincondiff]

Great work @FezVrasta! 👏

[Angelk90]

@austincondiff , @FezVrasta : It would be possible to change the icon here too and add the same one that was used for the branch as xcode does.

[FezVrasta]

[Angelk90]

@FezVrasta : Great.

[Angelk90]

@FezVrasta : I join @activcoding's proposal, do you think it's too demanding?

[activcoding]

@FezVrasta : I join @activcoding's proposal, do you think it's too demanding?

I reckon the popover style is more important. We can throw in those finer details in a later PR

[austincondiff]

Yeah, let's merge this PR. We are scope creeping quite a bit here imo. Looks good enough to merge.

[Angelk90]

@activcoding : If anything, can you try to add these details yourself?

[FezVrasta]

@FezVrasta thanks for the PR! Got some questions:

1: Can we use the popover? I really like its style:

2. How about more symbols for branches and a coloured checkmark for the current branch?

3. Any chance to add more details to each branch section?

I used the Menu component because it has built-in keyboard support, we can definitely use the Popover but I think we'll have to build keyboard support from scratch?

[activcoding]

@FezVrasta thanks for the PR! Got some questions:
1: Can we use the popover? I really like its style:

2. How about more symbols for branches and a coloured checkmark for the current branch?

3. Any chance to add more details to each branch section?

I used the Menu component because it has built-in keyboard support, we can definitely use the Popover but I think we'll have to build keyboard support from scratch?

Ok, great choice going with the Menu component. Your work looks fantastic—let's get this merged! If @austincondiff adds me as a reviewer, I'd be more than happy to go through your changes.

[activcoding]

@activcoding : If anything, can you try to add these details yourself?

I don't like your tone here; it feels a bit demanding. Nevertheless, I've got a lot on my plate with a few PRs in progress. Once those are sorted, I'll definitely take a look at the issue.

[Angelk90]

@activcoding : He didn't want to be, I really liked your idea.

[0xWDG]

Nice work!