Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Refactor STTextViewController to reduce duplication #185

Merged
merged 13 commits into from
May 16, 2023

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented Apr 30, 2023

Description

Fixed a few UI bugs by reducing overlap between loadView and reloadUI and calling reloadUI from loadView. These include...

  • There were some areas where the theme background was not getting applied.
  • The currently selected line was not getting a background in the ruler view until changing a setting which called reloadUI.

Now loadView calls reloadUI which allows us to reduce code duplication

Related Issues

  • n/a

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

n/a

@austincondiff austincondiff changed the title UI bugs fixes [chore] Refactor STTextViewController to reduce duplication May 9, 2023
@austincondiff austincondiff merged commit 1dfd0b5 into main May 16, 2023
@austincondiff austincondiff deleted the textview-ui-fixes branch May 16, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants