Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Refactor STTextViewController to reduce duplication #185

Merged
merged 13 commits into from
May 16, 2023
Merged

[chore] Refactor STTextViewController to reduce duplication #185

merged 13 commits into from
May 16, 2023

Commits on Apr 30, 2023

  1. Fixed a few bugs by reducing overlap between loadView and reloadUI an… 

    …d calling reloadUI from loadView.
    @austincondiff
    austincondiff committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    66c6f3b View commit details
    Browse the repository at this point in the history

  2. Added note about crash

    @austincondiff
    austincondiff committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    8edd22f View commit details
    Browse the repository at this point in the history

  3. Removed more unnecessary code from loadView

    @austincondiff
    austincondiff committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    aae296e View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Fixed test

    @austincondiff
    austincondiff committed May 6, 2023
    Configuration menu
    Copy the full SHA
    f5e6f74 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Merge branch 'main' into textview-ui-fixes

    @austincondiff
    austincondiff committed May 9, 2023
    Configuration menu
    Copy the full SHA
    d426511 View commit details
    Browse the repository at this point in the history

  2. Update STTextViewController+Lifecycle.swift

    @austincondiff
    austincondiff committed May 9, 2023
    Configuration menu
    Copy the full SHA
    09f3bba View commit details
    Browse the repository at this point in the history

  3. Update STTextViewController+Lifecycle.swift

    @austincondiff
    austincondiff committed May 9, 2023
    Configuration menu
    Copy the full SHA
    5f62590 View commit details
    Browse the repository at this point in the history

  4. Removed loadView in response to merged changes and cleaned up reloadUI.

    @austincondiff
    austincondiff committed May 9, 2023
    Configuration menu
    Copy the full SHA
    e1f30b6 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'refs/remotes/upstream/textview-ui-fixes' 

    Conflicts:
	Sources/CodeEditTextView/Controller/STTextViewController.swift
    @austincondiff
    austincondiff committed May 9, 2023
    Configuration menu
    Copy the full SHA
    ea1c5fd View commit details
    Browse the repository at this point in the history

  6. Fixed SwiftLint error

    @austincondiff
    austincondiff committed May 9, 2023
    Configuration menu
    Copy the full SHA
    6c78518 View commit details
    Browse the repository at this point in the history

  7. Fixed test

    @austincondiff
    austincondiff committed May 9, 2023
    Configuration menu
    Copy the full SHA
    8711293 View commit details
    Browse the repository at this point in the history

  8. Removed unnecessary optional chaining.

    @austincondiff
    austincondiff committed May 9, 2023
    Configuration menu
    Copy the full SHA
    6070815 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Merge branch 'main' into textview-ui-fixes

    @austincondiff
    austincondiff committed May 10, 2023
    Configuration menu
    Copy the full SHA
    50648ae View commit details
    Browse the repository at this point in the history