Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Package to CodeEditSourceEditor #223

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Rename Package to CodeEditSourceEditor #223

merged 3 commits into from
Dec 13, 2023

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Dec 12, 2023 •
edited

Description

  • Changes the package name to CodeEditSourceEditor.
  • Uses the new CodeEditTextView repository instead of containing two targets for the source editor and text view.
  • Updates all repo names, fixes all headers (thanks @0xWDG for pointing that out in Custom Text View #211).
  • Marks the CodeEditTextView struct as deprecated in favor of CodeEditSourceEditor.
  • Fixes a small bug with cursor position that left out column info.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

@thecoolwinter thecoolwinter enabled auto-merge (squash) December 13, 2023 01:07
@thecoolwinter thecoolwinter merged commit e08a43e into CodeEditApp:main Dec 13, 2023
2 checks passed
@thecoolwinter thecoolwinter deleted the rename branch December 13, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thecoolwinter @austincondiff