Custom Text View #211
Merged
Custom Text View #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing CETiledLayer due to the fact that the layer refuses to draw fast, resulting in a laggy view when resizing that takes seconds to redraw and leaves artifacts behind while resizing.
**Needs work**
thecoolwinter
force-pushed
the
feat/inputview
branch
from
5283fbb
to
0016b1d
Compare
|
@matthijseikelenboom I tend to add |
|
This is finally ready for some review! |
matthijseikelenboom
previously approved these changes
Nov 21, 2023
0xWDG
reviewed
Dec 7, 2023
0xWDG
previously requested changes
Dec 7, 2023
There was a problem hiding this comment.
Looks good, great work!
I have 2 notes.
-
see requested change, this header filename isn't right.
-
there is no consistency in the header docs
In some filesCodeEditTextViewis in the header docs, in others it isn't, this is not breaking but looks a bit weird to me.
//
// FILENAME.swift
//
//
// Created by Khan Winter on 11/14/23.
//And in others
//
// FILENAME.swift
// CodeEditTextView
//
// Created by Khan Winter on 11/14/23.
//
Co-authored-by: Wesley de Groot <email@wesleydegroot.nl>
austincondiff
approved these changes
Dec 9, 2023
matthijseikelenboom
approved these changes
Dec 9, 2023
This was referenced Dec 20, 2023
This was referenced Dec 9, 2023
Closed
thecoolwinter
added a commit
that referenced
this pull request
Dec 13, 2023
<!--- IMPORTANT: If this PR addresses multiple unrelated issues, it will be closed until separated. --> ### Description - Changes the package name to CodeEditSourceEditor. - Uses the new CodeEditTextView repository instead of containing two targets for the source editor and text view. - Updates all repo names, fixes all headers (thanks @0xWDG for pointing that out in #211). - Marks the `CodeEditTextView` struct as deprecated in favor of `CodeEditSourceEditor`. - Fixes a small bug with cursor position that left out column info. ### Checklist <!--- Add things that are not yet implemented above --> - [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md) - [x] The issues this PR addresses are related to each other - [x] My changes generate no new warnings - [x] My code builds and runs on my machine - [x] My changes are all related to the related issue above - [x] I documented my code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces
STTextViewwith a custom TextView implementation. Creates a newTextViewandTextViewControllerclasses that manage rendering text, handling text input, and keybinds.TextViewControllerreplaces theSTTextViewControllerclass, connecting existing TextFormation classes, syntax highlighting, and other existing text view extensions.Related Issues
Checklist
TextView TODOs:
MacOS Sonoma cursorLeaving for future PR. Will require rework of cursor view system.--
Screenshots
// TODO