Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ macOS Sonoma Cursor #5

Closed
austincondiff opened this issue Dec 9, 2023 · 0 comments · Fixed by #21
Closed

✨ macOS Sonoma Cursor #5

austincondiff opened this issue Dec 9, 2023 · 0 comments · Fixed by #21
Labels
enhancement New feature or request

Comments

@austincondiff
Copy link
Contributor

austincondiff commented Dec 9, 2023

Description

We should update the cursor in our editor to use the new cursor style Apple released with macOS Sonoma.

Originally planned for CodeEditApp/CodeEditSourceEditor#211 but was cut to reduce PR complexity.

@thecoolwinter feel free to edit to provide additional details.

@austincondiff austincondiff added the enhancement New feature or request label Dec 9, 2023
@austincondiff austincondiff transferred this issue from CodeEditApp/CodeEditSourceEditor Dec 20, 2023
thecoolwinter added a commit that referenced this issue Feb 21, 2024
### Description

Adds the ability to use the system cursor if available and enabled using a `useSystemCursor` variable on either `TextView` or `TextSelectionManager`.

### Related Issues

*  closes #5

### Checklist

<!--- Add things that are not yet implemented above -->

- [x] I read and understood the [contributing guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md) as well as the [code of conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code

### Screenshots

Example usage in CodeEditSourceEditor:

https://github.com/CodeEditApp/CodeEditTextView/assets/35942988/5b5adeee-dd80-4f92-92d0-121be18ab6ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏁 Complete
Development

Successfully merging a pull request may close this issue.

1 participant