Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hurumap packaging #77

Merged
merged 10 commits into from
Aug 18, 2018
Merged

Hurumap packaging #77

merged 10 commits into from
Aug 18, 2018

Conversation

KhadijaMahanga
Copy link
Contributor

Description

Deleted HURUmap folder, added hurumap package and minor templates customization on apps.

Fixes #68

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

requirements.txt Outdated

git+https://github.com/CodeForAfricaLabs/HURUmap.git@develop#egg=hurumap

git+https://github.com/CodeForAfricaLabs/wazimap.git@master#egg=wazimap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think wazimap is included in HURUmap package as a requirement already?

@KhadijaMahanga
Copy link
Contributor Author

@DavidLemayian @kilemensi updated the requirements.txt

@KhadijaMahanga
Copy link
Contributor Author

@kilemensi @DavidLemayian I have added back the wazimap github url in requirements to override one that is downloaded from PyPI. The one from PyPI has some error, that breaks migration run when running HURUmap-apps (models don't get all migrated and we get programming error of - table relation do not exist ) cc @phillipahereza

@kilemensi kilemensi changed the base branch from develop to master August 16, 2018 12:30
 + Add missing DROP IF EXISTS statements
 + Remove unnessary OWNER TO statements
@kilemensi kilemensi merged commit ba516df into master Aug 18, 2018
@kilemensi kilemensi deleted the hurumap-packaging branch August 18, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package HURUmap
3 participants