629: Limit Search to Philadelphia #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgrimes86 is attempting to deploy a commit to the Clean and Green Philly Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks @jgrimes86! @CodeWritingCow PR review? |
CodeWritingCow
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Hi @jgrimes86 I ran your code in my local environment, and it worked as intended. A search for "120 Walnut St" returns results from Philadelphia only. Searching for "Philadelphia, Mississippi" returns no results. Thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bounding box and filter to the mapbox geocoder to limit search results to addresses located in Philadelphia.
The filter limits search results to items that have a place feature of 'Philadelphia' or a district feature of 'Philadelphia County'. The bounding box limits search results to a rectangular area around Philadelphia, PA so that the search doesn't return results from other places named Philadelphia, such as Philadelphia, Mississippi.
This closes issue #629