-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze Queue #224
Freeze Queue #224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me as long as it is functioning.
i made one small comment about inline styles, but otherwise, get the branch up to date and ill approve it
29a1b4b
to
a5eeb1e
Compare
@MikeyManoguerra thanks for the review. I revamped this a little bit. Instead of just blindly flipping the state when its clicked the button will wait for a valid server response. I also went a fixed the AllQueue.test.js file since it was failing due to some other PR's. Also added a test for the button. Probably want to give this a once over again. |
Looks good! Some things outside the scope of this ticket we'll need to think about:
|
a5eeb1e
to
5597b99
Compare
@MikeyManoguerra Yea I noticed the is closed. if its decided later to use that instead it should be easy to switch over. ill get the branch updated and merged. |
I guess by rebasing it invalidates the review. Sorry mind approving again and ill get this merged. @MikeyManoguerra |
@ThrowsException they're moving too fast! message me on slack and ill see this quicker |
Makes the program not selectable from the participant info form if the program has been marked as frozen from the queue
5597b99
to
753cead
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
#214
Makes the program not selectable from the participant info form if the program has been marked as frozen from the queue