261 logout pop up #427
261 logout pop up #427
Conversation
| import { reverseObject } from '../services/reverseObject'; | ||
|
|
||
| const { user } = store.state; | ||
| const { user } = store ? store.state : { user: undefined }; |
There was a problem hiding this comment.
| const { user } = store ? store.state : { user: undefined }; | |
| const { user } = store && store.state ? store.state : { user: undefined }; |
?
Co-Authored-By: Artur Tamborski <tamborskiartur@gmail.com>
…m into 261-logout-pop-up
|
I have a question - should this modal be displayed only when user is offline? It's not described as that in the linked issue (although there isn't much detail either), so maybe we should discuss this? Other thing - I'm not an UX guy, don't know much about that but I thought it would be nice to have the buttons separated from each other, just as we did in DriveFromView with Submit and Reset. |
|
Confirmed with Client, that we need displaying pop up when user is online as well. |
|
No need to, I think that all work can be done in this PR, as it's still open :) |
|
In case this was lost somehow: we'd love to display the pop-up developed here no matter the network status (online/offline). Currently it works so it's shown only when user is offline - this can be surprising when the user temporarily gains network connection. Please modify the PR such that the pop-up always pops up - thanks! |
|
Sorry for the delay but I was unable to get on this. I think in the next meeting I will end this as it sounds easy to implement. |
|
This should be ok now |
I added modal that will show the warning to user attempting logout on offline.
I also moved routes to a separate file because there were problem with import, that finally wasn't needed. But I think it's ok to leave it that way.