Fixes scroll when viewing Markdown files #664
Conversation
|
Thanks I have been trying see what issues other people are having with the
ras pi
…On Sun, Apr 19, 2020 at 11:51 PM Bibek Shrestha ***@***.***> wrote:
Fixes #651 <#651> #650
<#650> #632
<#632> #613
<#613>
Due to the overflow: hidden, when you open a Readme.md or any other
markdown file on iOS, it scrolling is completely disabled.
With this, you should be able to scroll again!
------------------------------
You can view, comment on, or merge this pull request online at:
#664
Commit Summary
- Fixes scroll when viewing Markdown files
File Changes
- *M* CodeHub/WebViews/MarkdownWebView.cs
<https://github.com/CodeHubApp/CodeHub/pull/664/files#diff-928bae6838d159d0192914d17f97de64>
(7)
- *M* CodeHub/WebViews/MarkdownWebView.cshtml
<https://github.com/CodeHubApp/CodeHub/pull/664/files#diff-fa2a8f48d6bffff21721fa5b5c48b57c>
(1)
Patch Links:
- https://github.com/CodeHubApp/CodeHub/pull/664.patch
- https://github.com/CodeHubApp/CodeHub/pull/664.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#664>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOX44A2YBHH3RUEVOC4CYHDRNPBFZANCNFSM4MMC67VA>
.
|
|
Nope still doesn’t allow for scrolling. |
|
Replay what??
Marcelo Carvalho
Em 21 de abr de 2020 02:25 -0300, Faraz <notifications@github.com> escreveu:
… Nope still doesn’t allow for scrolling.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Did you try compiling the changes and loading it on a simulator or your iPhone? |
|
Good luck. This app hasn’t received an update in a year. The author/maintainer of the App Store app is MIA. |
|
Outstanding work @bibstha! I will work to produce a new image for the app store. Thank you for your contribution! |
|
Hi @thedillonb any chance of a new release soon? I use it to read and write my notes and this fix will make the experience much better. |
|
@bibstha yes. It's actually in progress right now. There was an issue with the GitHub account I traditionally give to Apple to use in reviewing the application. |
|
I can confirm that the scrolling issue is now resolved! Download the latest version from the App Store (with a nice shoutout to @bibstha in release description), v2.19.1, which was released about a week ago. Thank you thank you thank you 😍 |
Fixes #654 #651 #650 #632 #613
Due to the
overflow: hidden, when you open a Readme.md or any other markdown file on iOS, it scrolling is completely disabled.With this, you should be able to scroll again!
Screenshot: https://drive.google.com/open?id=1y4OAwe2qyTG1ATHT7upZiZTnjjxFHNXx
cc: @thedillonb