all: Rework Opt value handling #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
FUZZ-582-refactor-config
branch
from
cd73e68
to
46ac931
Compare
fmeum
changed the title
fmeum
force-pushed
the
FUZZ-582-refactor-config
branch
3 times, most recently
from
3c17113
to
8181236
Compare
fmeum
commented
Jun 15, 2023
fmeum
force-pushed
the
FUZZ-582-refactor-config
branch
from
8181236
to
5a62871
Compare
fmeum
changed the title
bertschneider
force-pushed
the
FUZZ-582-refactor-config
branch
from
5a62871
to
e7d44a5
Compare
bertschneider
approved these changes
Jun 19, 2023
This is a complete rewrite of the logic underlying `Opt`, with the following notable changes: * All options are now evaluated lazily, with safeguards ensuring that there can be no attempts to modify their defaults after they have been read once. This reduces the risk of accidentally locking in `Opt` and then reading stale values due to its previous reliance on static initializers. * There are now clear precedence rules for all options and every option can be set from all possible sources: manifest entries, env variables, system properties, configuration parameters, command-line arguments. In follow-up PRs, the new capabilities of `OptItem` (e.g. accumulating settings and JUnit configuration parameters as sources) will be used in Jazzer. Co-authored-by: Brian Lewis <brian.lewis@code-intelligence.com>
bertschneider
force-pushed
the
FUZZ-582-refactor-config
branch
from
e7d44a5
to
1700688
Compare
br-lewis
suggested changes
Jun 19, 2023
br-lewis
approved these changes
Jun 19, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of the logic underlying
Opt, with thefollowing notable changes:
there can be no attempts to modify their defaults after they have been
read once. This reduces the risk of accidentally locking in
Optand then reading stale values due to its previous reliance on static
initializers.
can be set from all possible sources: manifest entries, env variables,
system properties, configuration parameters, command-line arguments.
In follow-up PRs, the new capabilities of
OptItem(e.g. accumulatingsettings and JUnit configuration parameters as sources) will be used in
Jazzer.