Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Snippet Editor to "Final Boss Castle" and block appropriately #28

Closed
4 tasks done
jhmullen opened this issue Jul 20, 2017 · 1 comment
Closed
4 tasks done

Move Snippet Editor to "Final Boss Castle" and block appropriately #28

jhmullen opened this issue Jul 20, 2017 · 1 comment
Assignees
@jhmullen
Labels
priority: high type: enhancement

Comments

@jhmullen
Copy link
Collaborator

jhmullen commented Jul 20, 2017 •
edited
Loading

Move the current Editor so that it exists as a popover after the final minilesson, with validation.

  • apply blocking logic to castle
  • fix submit/close buttons
  • break out validation errors
  • move "island completion" to after submitting passing code
@jhmullen jhmullen mentioned this issue Jul 20, 2017
Closed
2 tasks
@alexandersimoes alexandersimoes mentioned this issue Jul 21, 2017
Closed
6 tasks
@jhmullen jhmullen changed the title Move Snippet Editor to "Final Test Slide" of final minilesson Move Snippet Editor to "Final Boss Castle" and block appropriately Jul 26, 2017
@jhmullen jhmullen self-assigned this Jul 26, 2017
@jhmullen jhmullen added this to the Thu July 27th milestone Jul 26, 2017
jhmullen added a commit that referenced this issue Jul 26, 2017
@jhmullen
addresses first part of issue #28 by blocking final castle
7f90b60
jhmullen added a commit that referenced this issue Jul 27, 2017
@jhmullen
breaks out validation rules, working on #28
a9448f1
jhmullen added a commit that referenced this issue Jul 27, 2017
@jhmullen
adds progress bar to codeblock editor for #28
0b2c31e
@jhmullen
Copy link
Collaborator Author

Final blocking castle now has broken out rules and will not save unless it's considered passing. Also has logic so that only your first "successful save" will cause an island to be beaten, unlocking the next island. Closing this issue (though it needs more design loving, but that's another issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhmullen jhmullen

Labels
priority: high type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhmullen