Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guzzle #168

Closed
wants to merge 14 commits into from
Closed

Guzzle #168

wants to merge 14 commits into from

Conversation

benallfree
Copy link
Contributor

A small update to introduce Guzzle support rather than raw curl. This feels more reliable to me and also fixes a couple bugs in createFromUrl:

  1. The old implementation saved responses even when they were not 200 HTTP status
  2. The old implementation loaded the whole response into memory before saving. This saves directly to file, far more memory efficient.

These can be accomplished with raw curl too, but I felt Guzzle modernized things a bit and made the process more reliable. Guzzle also supports environments without curl.

@benallfree benallfree closed this Aug 12, 2016
@benallfree
Copy link
Contributor Author

Bad push

@benallfree benallfree deleted the guzzle branch August 13, 2016 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant