-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Tags on study group opening creation page #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
saseungmin
commented
Nov 23, 2020
•
edited
Loading
edited
- 스터디 그룹 개설(작성) 페이지의 태그에 대한 작업
- 태그 추가
- 태그 삭제
- write study creation page input tags
saseungmin
commented
Nov 24, 2020
Comment on lines
+47
to
+69
<TagsFormWrapper> | ||
<h4>태그</h4> | ||
<input | ||
type="text" | ||
placeholder="태그를 입력하세요" | ||
value={tag} | ||
onChange={handleChange} | ||
onKeyPress={handleSubmit} | ||
/> | ||
<div> | ||
{inputTags.map((inputTag) => ( | ||
<span | ||
key={inputTag} | ||
onClick={() => handleRemove(inputTag)} | ||
onKeyPress={() => {}} | ||
role="button" | ||
tabIndex="-1" | ||
> | ||
{`#${inputTag}`} | ||
</span> | ||
))} | ||
</div> | ||
</TagsFormWrapper> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 리팩토링 하기 컴포넌트 분리하기
Comment on lines
11
to
27
<input type="text" placeholder="제목을 입력하세요" /> | ||
</div> | ||
<div> | ||
<textarea rows="10" cols="100" placeholder="내용" /> | ||
<span>모집 마감 날짜</span> | ||
<input type="date" /> | ||
</div> | ||
<div> | ||
<input type="text" placeholder="태그를 입력하세요" /> | ||
<span>참여 인원 수</span> | ||
<input type="number" /> | ||
</div> | ||
<div> | ||
<textarea rows="10" cols="100" placeholder="내용" /> | ||
</div> | ||
<TagFormContainer /> | ||
<div> | ||
<button type="button">저장</button> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 컴포넌트 분리하기
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.