[Feature] Deploy after changing to firestore #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
saseungmin
commented
Nov 28, 2020
•
saseungmin
commented
- json-server에서 firestore로 변경
- firebase에 호스팅
- change from json-server to firestore
- firebase initial settings - deploy with firebase
saseungmin
commented
Nov 28, 2020
Comment on lines
+4
to
+11
| const response = await db.collection('groups').get(); | ||
|
|
||
| const groups = response.docs.map((doc) => ({ | ||
| ...doc.data(), | ||
| id: doc.id, | ||
| })); | ||
|
|
||
| return groups; |
There was a problem hiding this comment.
- 테스트를 어떻게 할 수 있을까...
There was a problem hiding this comment.
해당 테스트를 왜 해야하나요? 이 부분을 테스트함으로써 어떤 확신을 얻을수 있을까요?
개인적으로는 API의 테스트가 굉장히 애매한것 같아요 ㅎㅎ 프론트보단 백엔드 쪽에서 API 기능 자체를 테스트 하는게 맞을 것같고, 만약 fetcher helper와 같이 프론트에서 처리를 해주는 부분이 있다면 그 부분은 프론트 테스트가 필요하겠죠.
There was a problem hiding this comment.
그렇군요.. 😢
아직 테스트를 작성하는데 있어서 부족함이 있는 거 같습니다.
리뷰 감사합니다!
Comment on lines
+15
to
+21
| const response = await db.collection('groups').doc(id).get(); | ||
|
|
||
| if (!response.exists) { | ||
| return null; | ||
| } | ||
|
|
||
| return response.data(); |
There was a problem hiding this comment.
- 방법은 있는거 같은데 활용이 안된다.
|
|
드디어 동료분들께 공유할 수 있게 됐네요~ 👏👏👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.