Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hamming.py #40

Merged
merged 2 commits into from Dec 24, 2018
Merged

hamming.py #40

merged 2 commits into from Dec 24, 2018

Conversation

udisinghania
Copy link
Contributor

@udisinghania udisinghania commented Dec 24, 2018

Please make sure you have done the following:

  • Created a folder with the name of language you code inside /Day<n>/ directory (Where n is for nth day)
  • Added your Codes
  • Tested your codes
  • Added credits (author and date) at the top of the code
  • Updated README.md
  • Added yourself as a contributor using all-conributors-cli

Copy link
Member

@MadhavBahl MadhavBahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with the code @udisinghania

Please add one more condition which checks whether the lengths of the strings are equal or not, and also add credits on top of your code

/**
 * @author uditsinghania
 * @Date 24/12/2018
*/

Thanks

@Razdeep
Copy link
Collaborator

Razdeep commented Dec 24, 2018

LGTM, @udisinghania. Merging the PR.

@Razdeep Razdeep dismissed MadhavBahl’s stale review December 24, 2018 11:36

hamming.py updated

@Razdeep Razdeep merged commit 813fbac into CodeToExpress:master Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants