Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day 4 ruby #54

Closed
wants to merge 26 commits into from
Closed

Day 4 ruby #54

wants to merge 26 commits into from

Conversation

aaditkamat
Copy link
Contributor

Please make sure you have done the following:

  • Created a folder with the name of language you code inside /Day<n>/ directory (Where n is for nth day)
  • Added your Codes
  • Tested your codes
  • Added credits (author and date) at the top of the code
  • Updated README.md
  • Added yourself as a contributor using all-conributors-cli

Aadit Rahul Kamat and others added 26 commits December 21, 2018 22:25
# Conflicts:
#	.all-contributorsrc
#	CONTRIBUTORS.md
#	Day1/README.md
@MadhavBahl
Copy link
Member

MadhavBahl commented Dec 25, 2018

Why are there 2 ## Ruby Implementation headings?

Why is there a python solution under Ruby heading?

Still there are many of those lines which appear while resolving merge conflicts. Please be more careful, and maintain a proper structure of README.md

Closing this PR. By seeing the number of commits I guess that you are facing problems in resolving merge conflicts.

Please take a pull from original repo once again, and add your code to the fresh repository.

Thanks for the contribution, but please be careful from next time.

@MadhavBahl MadhavBahl closed this Dec 25, 2018
@MadhavBahl
Copy link
Member

Also, what have you changed in CONTRIBUTORS.md file? Your name already exists in the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants