Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited my python solution for day 7 #92

Merged
merged 29 commits into from Dec 31, 2018

Conversation

vishalshirke7
Copy link
Contributor

Please make sure you have done the following:

  • Created a folder with the name of language you code inside /Day<n>/ directory (Where n is for nth day)
  • Added your Codes
  • Tested your codes
  • Added credits (author and date) at the top of the code
  • Updated README.md
  • Added yourself as a contributor using all-conributors-cli

@vishalshirke7
Copy link
Contributor Author

Hi @MadhavBahlMD, the python solution for day 7 which I had implemented using set intersection was failing for some test cases, so I have changed it.

@MadhavBahl
Copy link
Member

Thanks for correction @vishalshirke7 👍

@MadhavBahl MadhavBahl merged commit bfc5ecc into CodeToExpress:master Dec 31, 2018
profgrammer pushed a commit to profgrammer/dailycodebase that referenced this pull request Dec 31, 2018
* Add @vishalshirke7 as a contributor

* Update @vishalshirke7 as a contributor

* Added python solutions for Day 4

* modified readme

* Add @Vishal

* reverted adding as a contributor

* Update README.md

* Update CONTRIBUTORS.md

* Update CONTRIBUTORS.md

* Added python solutions for day 7

* Edited python solution for day 7

* Edited python solution for day 7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants