Windows environment fixes #2
Conversation
EswarBalasubramanian
commented
Jan 21, 2024
•
EswarBalasubramanian
commented
- Updated opencv package version
- adb screenshot command issue fixed
- image_compare max_val reduced tolerance by 0.05 to execute properly in bigger screen sizes.
| @@ -102,13 +103,19 @@ def run(): | |||
| val, coords = 0, None | |||
|
|
|||
| # Update the maximum value and corresponding image file and coordinates if necessary | |||
| if val > max_val: | |||
| # if val > max_val: | |||
| if ('max_number_of_games_played_text.en.png' == image_file and val > 0.42): | |||
There was a problem hiding this comment.
Can you explain why you use val > 0.42? I tested the changes from your PR and I had to change this to 0.43. With 0.42 it detected every screen as max number of games played and just stopped.
There was a problem hiding this comment.
when I used it in my small android device, even after capturing the text in the screenshot, the bot unable to detect it and loops clicking the battle button. The 0.42 is the value where max games played screenshot score exceeds, battle button screenshot score
There was a problem hiding this comment.
OK. I have refactored quite a bit in the meantime. I had the same problem and added a priority list if multiple images match. See #4 and
PVPokeLossBot/src/image_decision_maker.py
Line 47 in 683f475
I have cherry picked your other changes for windows support in #3 and merged them.
