NW6 | Zeliha Pala | HTML-CSS | [TECH ED] Form Controls | Week 3 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-module-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ch4413
suggested changes
May 15, 2024
| @@ -0,0 +1,106 @@ | |||
| /* Reset some default styles */ | |||
There was a problem hiding this comment.
Great job on styling the CCS. It looks really good but I'm getting Lighthouse Accessibility score below 100 because of "Background and foreground colours not having a sufficient contrast ratio". How could you improve this?
| id="deliveryDate" | ||
| name="deliveryDate" | ||
| required |
There was a problem hiding this comment.
Great work on the HTML element restrictions. On the date min and max, what could you change so that it dynamic changes to min=Today and max=Today+4 weeks?
This is a little trickier and requires JS or PHP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.