NW6/Sabella Fissha/js1/week1 #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2023 12:56
BakhatBegum
reviewed
Nov 15, 2023
Comment on lines
+1
to
+3
| // We don't want the computer to run these 2 lines - how can we solve this problem? | ||
| // we can comment out , the thing we don't want he computer to run it. |
There was a problem hiding this comment.
Well done! You have accurately performed the required task. I noticed a spelling error to correct.
Comment on lines
+3
to
4
| let age = 33; | ||
| age = age + 1; |
Comment on lines
3
to
+4
| const cityOfBirth = "Bolton"; | ||
| console.log(`I was born in ${cityOfBirth}`); |
| @@ -1,6 +1,6 @@ | |||
| const cardNumber = 4533787178994213; | |||
| let cardNumber = "4533787178994213"; | |||
There was a problem hiding this comment.
You did well, using numbers as a string.
Comment on lines
+1
to
+2
| const twentyfourHourClockTime = "08:53"; |
Comment on lines
+15
to
+20
| // --> 5 function calls. | ||
| // --> Number | ||
| // --> ReplceAll | ||
| // --> Number | ||
| // --> ReplaceAll | ||
| // --> percentageChange |
Comment on lines
+25
to
+28
| // --> let carPrice = "10,000"; | ||
| // --> let priceAfterOneYear = "8,543"; | ||
| // --> const priceDifference = carPrice - priceAfterOneYear; | ||
| // --> const percentageChange = (priceDifference / carPrice) * 100; |
Comment on lines
+18
to
+19
| // b) How many function calls are there? | ||
| // --> There is no function call. |
Comment on lines
+31
to
+33
| // --> Division by zero. | ||
| // --> Floating numbers (decimal). | ||
| // --> The result will be unknown. |
There was a problem hiding this comment.
You did great i appreciate your job. In my point of view, it is infinity. because 0 / by something will be infinity.
Comment on lines
+29
to
+41
| // 1. const penceString = "399p": initializes a string variable with the value "399p" | ||
| // 2. penceString.length = 4 : total number of count of a string. | ||
| // 3. penceString.length - 1 = 3 | ||
| // 4. penceString.substring(0,penceString.length - 1); -> penceString.substring(0,3) | ||
| // 5. penceString.substring(0,3); = 399: it selects character between (0,3) so it remove "p". | ||
| // 6. penceStringWithoutTrailingP.padStart(3, "0"); : 399 has already 3 character and the padStart ask to add "o" upto having three digit. | ||
| // 7. paddedPenceNumberString = 399; | ||
| // 8. paddedPenceNumberString.length - 2 = 1; | ||
| // 9. pound = paddedPenceNumberString.substring( 0,1) = 3; | ||
| // 10. paddedPenceNumberString.substring(paddedPenceNumberString.length - 2)--> paddedPenceNumberString.substring(3 - 2) | ||
| // 11. 399.paddedPenceNumberString.substring(3 - 2)= 99; | ||
| // 12. pence= 99.padEnd(2,"0")--> 99 has already 2 digit so no need to add "0"; | ||
| // 13. console.log(`£${pounds}.${pence}`);= 3.99; |
JayMayer
reviewed
Dec 11, 2023
| @@ -1,6 +1,7 @@ | |||
| let firstName = "Creola"; | |||
| let middleName = "Katherine"; | |||
| let lastName = "Johnson"; | |||
|
|
|||
| const initials = firstName.charAt(0)+ middleName.charAt(0) + lastName.charAt(0) | |||
There was a problem hiding this comment.
Be careful of the requirement "in upper case". Even though the initials are all uppercase in this example, that might not be true for all inputs.
JayMayer
reviewed
Dec 11, 2023
| // --> ReplceAll | ||
| // --> Number | ||
| // --> ReplaceAll | ||
| // --> percentageChange |
There was a problem hiding this comment.
All great except the last one, percentageChange is only a variable
JayMayer
reviewed
Dec 11, 2023
|
|
||
| // b) How many function calls are there? | ||
| // b) How many function calls are there? | ||
| // --> There is no function call. |
There was a problem hiding this comment.
console.log(..) could be considered a function call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
I HAVE DONE ALL THE EXERCISES