Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: custom js for individual sites #727

Merged
merged 1 commit into from
May 21, 2024
Merged

Feature: custom js for individual sites #727

merged 1 commit into from
May 21, 2024

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented May 20, 2024 •
edited
Loading

What does this change?

Common Theme?

Add a custom js insertion point in scripts.html

This matches custom-theme and custom-images so you can add your own little scripts to your own theme.

Test

Make a script and add it to assets/custom-scripts to concat, minify, and insert

If you make a whole component please contribute it back to the common theme though.

Org Content?

Module | Sprint | Page Type | Block Type

Checklist

Who needs to know about this?

@netlify Netlify
Copy link

netlify bot commented May 20, 2024 •
edited
Loading

✅ Deploy Preview for cyf-programming canceled.

Name Link
🔨 Latest commit e0416c1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/664b3cee14eca500081c11b9

@netlify Netlify
Copy link

netlify bot commented May 20, 2024 •
edited
Loading

✅ Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit e0416c1
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/664b3cee1a2f7000086a05d7

@SallyMcGrath SallyMcGrath changed the title pop custom js call in scripts partial Feature: custom js for individual sites May 20, 2024
Dedekind561
Dedekind561 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@Dedekind561 Dedekind561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Boom!

@Dedekind561 Dedekind561 merged commit 8c36de7 into main May 21, 2024
9 of 10 checks passed
@Dedekind561 Dedekind561 deleted the feature/custom-js branch May 21, 2024 17:40
SallyMcGrath added a commit that referenced this pull request May 22, 2024
@SallyMcGrath
add folders to other orgs
6ca50b2 
temp add folders to other orgs to stop them failing re #727
@SallyMcGrath SallyMcGrath mentioned this pull request May 22, 2024
Merged
5 tasks
SallyMcGrath added a commit that referenced this pull request May 23, 2024
@SallyMcGrath
Bugfix: #727 followup, stop failure on null (#731)
c1ccd20 
* add folders to other orgs

temp add folders to other orgs to stop them failing re #727

* rejig concat so it doesn't fail on null

and rm script to check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dedekind561 Dedekind561 Dedekind561 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Curriculum Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SallyMcGrath @Dedekind561