Style guide violation #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a style guide violation in line 166 and 167 so I change it according to style guide Signed-off-by: Mohit Bansal <78220157+MohitBansal321@users.noreply.github.com>
There is a style guide violation in line 54 so i change it according to style guide Signed-off-by: Mohit Bansal <78220157+MohitBansal321@users.noreply.github.com>
SallyMcGrath
requested changes
Jan 15, 2023
In lines 166,167 and 169 Signed-off-by: Mohit Bansal <78220157+MohitBansal321@users.noreply.github.com>
SallyMcGrath
requested changes
Jan 15, 2023
Signed-off-by: Mohit Bansal <78220157+MohitBansal321@users.noreply.github.com>
Signed-off-by: Mohit Bansal <78220157+MohitBansal321@users.noreply.github.com>
|
let me know all things are okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Module: js-core-1 , workshops
Week(s):week-4 , js-testing-workshop
#570 #569
Description
There is a style guide violation so I changed it according to style guide
Who needs to know about this?
@SallyMcGrath
Rendered Pages