Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edit] CSS [Edit] CSS Position: right() #4074

Open
3 tasks done
christian-dinh opened this issue Dec 11, 2023 · 56 comments · May be fixed by #4952
Open
3 tasks done

[Edit] CSS [Edit] CSS Position: right() #4074

christian-dinh opened this issue Dec 11, 2023 · 56 comments · May be fixed by #4952
Assignees
Labels
claimed Issue is claimed and closed to further assignment css CSS entries enhancement New feature or request good first issue Good for newcomers

Comments

@christian-dinh
Copy link
Contributor

christian-dinh commented Dec 11, 2023

Type of Edit (select all that apply)

Add new content (definitions, codeblocks, etc.)

Description (optional)

[PLEASE DO NOT WORK ON THIS ISSUE UNTIL YOU HAVE BEEN ASSIGNED] We would like an edit to a term within CSS Position. The term entry lives in docs/content/css/concepts/position/terms/right/right.md

Please refer to the term entry templates, content standards, and markdown style guide when working on the PR for this issue.

Please:

  1. Add supplemental media (preferred .png or .gif, <1MB).
  2. Media (images, gifs) should accurately represent the existing code blocks in the example sections and fit in-line. ex: See last image here

Code of Conduct

  • By submitting this issue, I agree to follow Codecademy Doc's Code of Conduct.

For Maintainers

  • Labels added
  • Issue is assigned
@christian-dinh christian-dinh added css CSS entries enhancement New feature or request good first issue Good for newcomers labels Dec 11, 2023
@manjhss
Copy link

manjhss commented Dec 12, 2023

@christian-dinh , I'd like to work on this issue.

@avdhoottt
Copy link
Collaborator

@surendra-manjhi You're assigned!🚀 You can check out the Contribution Guide for additional information on contributing.
See Content Standards for an overview of styling tips that the Style Guide covers in detail.
After creating a PR, maintainer(s) (with the collaborator label) will add in comments/suggestions to address any revisions prior to approving.

In addition, please head over to the Docs Forum if you have any questions about Docs or reply to the thread on Possible Content Discussion to share ideas and collaborate with other contributors, maintainers, or super users to determine good future issues that will help expand Docs!

If this is your first time contributing, can you let us know how you came across this repo?

@avdhoottt avdhoottt added the claimed Issue is claimed and closed to further assignment label Dec 12, 2023
@SSwiniarski
Copy link
Contributor

@surendra-manjhi It's been two weeks. Are you still working on this entry? Note that in another week it will be unassigned due to inactivity.

@SSwiniarski
Copy link
Contributor

@surendra-manjhi This is being unassigned due to inactivity.

@SSwiniarski SSwiniarski removed the claimed Issue is claimed and closed to further assignment label Jan 3, 2024
@agafirth
Copy link

agafirth commented Jan 5, 2024

Hi! Can I be assigned on this issue, please?

@SSwiniarski
Copy link
Contributor

@agafirth You're assigned! You can check out the Contribution Guide for additional information on contributing.
See Content Standards for an overview of styling tips that the Style Guide covers in detail.
After creating a PR, maintainer(s) (with the collaborator label) will add in comments/suggestions to address any revisions prior to approving.

In addition, please head over to the Docs Forum if you have any questions about Docs or reply to the thread on Possible Content Discussion to share ideas and collaborate with other contributors, maintainers, or super users to determine good future issues that will help expand Docs!

@SSwiniarski SSwiniarski added the claimed Issue is claimed and closed to further assignment label Jan 6, 2024
@juliajobczyk
Copy link
Contributor

Hi can I please be assigned?

@SSwiniarski
Copy link
Contributor

@juliajobczyk, @agafirth is already assigned to this issue.

@SSwiniarski
Copy link
Contributor

@agafirth It's been two weeks. Are you still working on this issue? Note that in another week it will be unassigned due to inactivity.

@SSwiniarski
Copy link
Contributor

@agafirth This is being unassigned due to inactivity.

@SSwiniarski SSwiniarski removed the claimed Issue is claimed and closed to further assignment label Jan 24, 2024
@RAFIMIKI
Copy link

RAFIMIKI commented Jan 24, 2024

hey i'm doing one of the swift skill paths and need to work on an issue via github, im good at html/css, can I be assigned?

(please email me if assigned to give me a heads up straight away) raf.sardinha@gmail.com

@SSwiniarski
Copy link
Contributor

@RAFIMIKI You're assigned! You can check out the Contribution Guide for additional information on contributing.
See Content Standards for an overview of styling tips that the Style Guide covers in detail.
After creating a PR, maintainer(s) (with the collaborator label) will add in comments/suggestions to address any revisions prior to approving.

In addition, please head over to the Docs Forum if you have any questions about Docs or reply to the thread on Possible Content Discussion to share ideas and collaborate with other contributors, maintainers, or super users to determine good future issues that will help expand Docs!

@SSwiniarski SSwiniarski added the claimed Issue is claimed and closed to further assignment label Jan 25, 2024
@RAFIMIKI
Copy link

hey quick question, the .md file that you linked is /bottom/bottom.md but the title says 'right()'. Am I supposed to edit /bottom/bottom.md or /right/right.md?

@SSwiniarski
Copy link
Contributor

@RAFIMIKI It should be right/right.md

@RAFIMIKI
Copy link

alright thanks :D

@SSwiniarski SSwiniarski linked a pull request Jan 29, 2024 that will close this issue
9 tasks
@RAFIMIKI
Copy link

RAFIMIKI commented Feb 2, 2024

hey it's done and if im not wrong it was successfully added :)
proofgithub#4074

@letsbuildanything letsbuildanything removed the claimed Issue is claimed and closed to further assignment label May 1, 2024
@letsbuildanything
Copy link
Collaborator

Hey @Dan-Tyas, @amal-george-8895 , and @nmatesa,
Let me know if any of you are still interested in working on this issue?"

@BenjamiLudvik
Copy link

Hello, I would like to work on this case if it is not claimed? If not, could you kindly assign it to me?

@Spremuta
Copy link

Spremuta commented May 4, 2024

Hi, can I be assigned on this issue? thank you!

@Johnnie-kay
Copy link
Contributor

Hello @letsbuildanything, I would love to work on this issue in case you are still considering who to assign it to.

@RohitMR10
Copy link

Hi @letsbuildanything, I would like to work on this issue. Can you please assign it to me?

@letsbuildanything letsbuildanything added the claimed Issue is claimed and closed to further assignment label May 10, 2024
@letsbuildanything
Copy link
Collaborator

@BenjamiLudvik You’re assigned 🎉 In addition to the documents linked in the description, please also look at the Contribution Guide. After creating a PR, the maintainer(s) (with the collaborator label) will add comments/suggestions to address any revisions prior to approval.
Is this your first contribution to Codecademy Docs? If so, we’re curious to know how you found out about contributing to Docs.

@BenjamiLudvik
Copy link

BenjamiLudvik commented May 10, 2024 via email

@scottfinamore
Copy link

Sorry, I was in the middle of working on this about to submit my first PR sorry it took me so long, was learning a lot on how to do it properly from a mentor.

@ishg-153
Copy link
Collaborator

Hey @scottfinamore, we typically wait for 2-3 weeks after the issue is assigned for the contributors to submit their PR.

We appreciate your interest in contributing to Codecademy. If you are still interested, please find an available issue of your liking and ask to be assigned to it.

@letsbuildanything
Copy link
Collaborator

@BenjamiLudvik its been a month. are you still working on this issue? Please note that if there's no activity within the next week, it will be unassigned.

Thank you!

@Johnnie-kay
Copy link
Contributor

Hello @letsbuildanything please assign me on this task if the other contributor doesn't respond within next week, I am a frontend web developer and would like to work on this issue. Thanks

@molivier1988
Copy link

I'm currently doing the Front End Web Development and git courses, so being able to contribute here would be a great learning experience but I can see there's lots of volunteers in this thread. But I'll ask anyway, please can I be assigned to this task?

@ishg-153
Copy link
Collaborator

@BenjamiLudvik This PR is being unassigned due to lack of activity.

@ishg-153 ishg-153 removed the claimed Issue is claimed and closed to further assignment label Jun 18, 2024
@ishg-153
Copy link
Collaborator

@molivier1988, @Johnnie-kay Are either of you still interested?

@molivier1988
Copy link

molivier1988 commented Jun 19, 2024 via email

@Johnnie-kay
Copy link
Contributor

Hello @ishg-153,yes I'm still interested in closing this issue. Thanks

@mamtawardhani
Copy link
Collaborator

Since @Johnnie-kay you are already working on two other issues, I'm assigning this to @molivier1988

@molivier1988 You’re assigned 🎉 In addition to the documents linked in the description, please also look at the Contribution Guide. After creating a PR, the maintainer(s) (with the collaborator label) will add comments/suggestions to address any revisions before approval.

Is this your first contribution to Codecademy Docs? If so, we’re curious to know how you found out about contributing to Docs.

@mamtawardhani mamtawardhani added the claimed Issue is claimed and closed to further assignment label Jun 19, 2024
@molivier1988
Copy link

Couple of questions about this issue please.

  1. Reading the https://www.codecademy.com/resources/docs/contribution-guide/getting-set-up-on-your-computer article it mentions creating a new .md file but wouldn't I just amend the original making references to any changes in the pull request?

  2. This assignment is to enhance this content with images showing effect of code, but I note that instead of using right top is used instead. Should I also amend this.

@yiro02
Copy link

yiro02 commented Sep 5, 2024

Si, pero si puedo ayudarte en español ya, que mi ingles no están bueno para darte una respuesta inmediata en ese idioma sin otro particular se despide: José Gabriel Hernández

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimed Issue is claimed and closed to further assignment css CSS entries enhancement New feature or request good first issue Good for newcomers
Projects
None yet