Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency injection support. Resolves #1115 #1164

Closed

Conversation

splinter89
Copy link
Contributor

I hope this will help with organizing of tests.

@DavertMik
Copy link
Member

👍 looks cool. I will need to review it and maybe propose some changes. Personally I don't feel that DI is really needed, but this PR is so nicely done, so I can't be against it ) Good job.

The only bad thing I see: this will work for Cest classes only. Let's see If we can add Codeception\TestCase\Test support as well.

And as it is major change I will ask you to send this PR into master branch, so it will go into 2.1 release.
Thanks. Also, would you mind to contact me in Skype? davert.ua

@splinter89
Copy link
Contributor Author

Thanks for the response!
The problem with Codeception\TestCase\Test is that PHPUnit_Framework_TestCase itself already has

public function __construct($name = null, array $data = array(), $dataName = '') {}

so it will break compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants