New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency injection support #1168
Dependency injection support #1168
Conversation
ce18ed4
to
365be4a
Compare
Thanks! Finally I merged this and it is now in master branch |
365be4a
to
236ce57
Compare
Here you go |
@splinter89 thanks, I already merged this manually. Probably I will need to discuss some points. Are you in Skype these days? |
I don't see it. Yes, I'm in Skype every day at work, usually 10am-6pm. |
Actually I did use this PR. This is how GitHub works, if PR can't be merged automatically it provides instructions to do that manually. Which actually I did. However it didn't track it. I merged your PR and I'm already working on moving everything to DI. I will push my changes to master later today.
|
I rebased this branch on top of master so you can merge it automatically now. |
Thank you, this branch is already merged. Di works really really smoothly on master and I feel really good of new features it brings! Thanks for good work! |
Resending #1164