-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproduced issue #1779 #1963
Reproduced issue #1779 #1963
Conversation
The simplest possible fix. |
Looks valid. |
Actually getClassesFromFile shouldn't include, it violates SRP. |
@@ -101,7 +101,7 @@ protected function addCommentStep($comment) | |||
|
|||
public static function getClassesFromFile($file) | |||
{ | |||
include_once $file; | |||
self::includeFile($file); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think anonymous function can be better here. At least it does just what needed - creates a new context without implementing a new method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it would look much uglier and be much slower.
Ok, thanks! |
Failing test for issue #1779