-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Db test refactoring #1985
Db test refactoring #1985
Conversation
Thanks, looks good. Waiting to get everything green there ) |
Seems that it broke things... |
It works for me! At least the DbTest. |
Looks like an issue with loading dump before the test. To be honest most of Db tests do not work for me, as I don't setup PostgreSQL or MySQL locally, instead I rely on Travis ) Please do not hurry, but could you find what goes wrong there? |
I will create a separate branch for debugging which will run DbTest only |
DbTest was green when executed in isolation: https://travis-ci.org/Codeception/Codeception/builds/64602009 |
I reproduced this test locally by running SqliteTest and DbTest in a group. [Groups] debug Unit Tests (654) --------------------------------------------------------------------------------------------------------------------------- |
I solved the issue by changing dsn in DbTest to avoid conflicts with SqliteTest. |
Adding this line fixed appveyor. Why does it work for other branches?
|
Appveyor holds a grudge against me. Start-Service : Failed to start service 'postgresql-x64-9.3 (postgresql-x64-9.3)'. |
I refactored SqliteTest and PostgresTest to be more in line with MysqlTest:
Moved initial setup to setUpBeforeClass,
load to setUp,
cleanup to tearDown.