facebook module - add support for facebook/php-sdk-v4 version 5 #2722
Conversation
| ))->execute(); | ||
|
|
||
| switch ($method) { | ||
| case 'GET' : |
There was a problem hiding this comment.
There must be no space before the colon in a CASE statement
| */ | ||
| public function seePostOnFacebookWithAttachedPlace($placeId) | ||
| public function seePostOnFacebookWithAttachedPlace($message) |
There was a problem hiding this comment.
Shouldn't it be named seePostOnFacebookWithMessage?
|
@tiger-seo Please review this pull request. |
|
@Naktibalda Thanks, I have added the changes, I am not sure why the WebDriverTest::testTextFieldByNameFirstNotCss failed in the previous commit, it is passing on my local machine |
|
WebDriver fails in random place in 1 run out of 10 or 20. |
|
ok thanks, good to know |
| @@ -4,22 +4,30 @@ | |||
| */ | |||
| namespace Codeception\Lib\Driver; | |||
|
|
|||
| use Facebook\FacebookSession; | |||
| use Facebook\FacebookRequest; | |||
| use Facebook\Facebook as Facebook_SDK; | |||
There was a problem hiding this comment.
this is not consistent with PSR, please, change to BaseFacebook or FacebookSDK
There was a problem hiding this comment.
Why not just FacebookSDK? That looks cleaner to me. It is not common to use underscores in class names (unless they come from a pre-namespace era).
|
|
||
| public function _depends() | ||
| { | ||
| return 'Codeception\Module\PhpBrowser'; | ||
| if ($this->config['depends'] == 'WebDriver') |
There was a problem hiding this comment.
Inline control structures are not allowed
| private function checkPublishPermissions() | ||
| { | ||
| if (!in_array('publish_actions', $this->config['test_user']['permissions']) || !in_array( | ||
| 'user_posts', |
There was a problem hiding this comment.
Multi-line function call not indented correctly; expected 12 spaces but found 16
|
Restarted tests. I hope this PR doesn't bring a BC break, right? If not, I think we can merge it. |
|
|
||
| return json_decode($response, true); | ||
| return $response->getDecodedBody(); |
There was a problem hiding this comment.
is this response is the same as it was with fb v4 ?
|
@orhan-swe please, resend your PR to branch ps. please, squash the commits 😉 |
|
This was wrong branch. A new pull request has been created for feature/facebook-upgrade branch: #2772 |
all test are passing now but the changes do break support for version 4 unfortunately