Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #3472 #3538

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Fix issue #3472 #3538

merged 1 commit into from
Sep 22, 2016

Conversation

eXorus
Copy link
Member

@eXorus eXorus commented Sep 22, 2016

Fix issue #3472

@Naktibalda
Copy link
Member

Thanks for the quick fix.
However I have no idea what is the effect of your change.

Could you implement a test for this issue in https://github.com/Codeception/Codeception/blob/2.2/tests/cli/RunCest.php ?

More information in https://github.com/Codeception/Codeception/tree/2.2/tests#cli

mcloide
mcloide reviewed Sep 22, 2016
View reviewed changes
Copy link

@mcloide mcloide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on code already existing on class it seems that it would work therefore the only way to confirm is with a test. Either way, good work.

Naktibalda added a commit to Naktibalda/Codeception that referenced this pull request Sep 22, 2016
@Naktibalda
Test running test with data provider by group Codeception#3538
f012840
@Naktibalda Naktibalda mentioned this pull request Sep 22, 2016
Merged
@Naktibalda Naktibalda merged commit ee1b9a9 into Codeception:2.2 Sep 22, 2016
Naktibalda added a commit to Naktibalda/Codeception that referenced this pull request Sep 22, 2016
@Naktibalda
Test running test with data provider by group Codeception#3538
2d04b0d
chris1312 pushed a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017
@Naktibalda
Test running test with data provider by group Codeception#3538
f8c7c89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcloide mcloide mcloide left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eXorus @Naktibalda @mcloide