Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Symfony5 class names in connectors #5670

Merged
merged 1 commit into from Sep 8, 2019

Conversation

@Naktibalda
Copy link
Member

commented Sep 6, 2019

#5532

Preparation for Symfony 5, also removes deprecation message when Symfony 4.3 components are used.

HttpKernelBrowser alias must be set in module file because Symfony/HttpKernel package isn't loaded yet by the time shim.php runs because it isn't dependency of Codeception.

@DavertMik

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

I thought that would be worse but I think we are fine with this fix. If class aliasing a few files fix this it is fine!

@Naktibalda Naktibalda merged commit 703a258 into 3.1 Sep 8, 2019
5 checks passed
5 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@Naktibalda Naktibalda deleted the symfony5-compatibility branch Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.