[Symfony] Make grabService use the special test service container if available #5706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @ThomasLandauer reported via #5073 quite some time ago,
grabService
seems to be somewhat broken for newer Symfony versions (>= 4.1 ?).With Symfony 4.1 a special service container was added that can be accessed via
test.service_container
for testing purposes which also provides access to private services:https://symfony.com/doc/current/testing.html#accessing-the-container
I also added a test to the symfony-demo project at Codeception/symfony-demo@master...burned42:add_service_container_test and if this PR will get accepted then I'd also open a PR for that branch.
I tried to let the CI run with these tests with:
3.1
as base: https://travis-ci.org/burned42/Codeception/builds/592157281So to me it seems like the issue is solved with these changes. Maybe someone more familiar with the Symfony module can also take a look at this :)