Merge tests repo

.gitattributes

@@ -4,3 +4,5 @@
 /Robofile.php    export-ignore
 /*.md            export-ignore
 /*.yml           export-ignore
+/tests           export-ignore
+/.github         export-ignore

.github/workflows/main.yml

@@ -27,21 +27,7 @@ jobs:
     - name: Install dependencies
       run: composer install --prefer-dist --no-progress --no-interaction --no-suggest
 
-    - name: Checkout Yii2
-      uses: actions/checkout@v2
-      with:
-        repository: Codeception/yii2-tests
-        path: framework-tests
-
-    - name: Install Yii2
-      run: |
-        composer require --no-update codeception/module-asserts
-        composer require --no-update codeception/module-filesystem
-        composer require --no-update codeception/codeception
-        composer update --no-dev --prefer-dist --no-interaction
-      working-directory: framework-tests
-
     - name: Run test suite
       run: |
-        php vendor/bin/codecept build -c framework-tests
-        php vendor/bin/codecept run -c framework-tests
+        php vendor/bin/codecept build
+        php vendor/bin/codecept run

.gitignore

@@ -1,4 +1,6 @@
 /.idea/
 /vendor/
 /composer.lock
-/framework-tests
+tests/_support
+tests/_output
+tests/cases/yii2-app-advanced/_data/db.sqlite

codeception.yml

@@ -0,0 +1,14 @@
+paths:
+    tests: tests
+    output: tests/_output
+    data: tests/_data
+    support: tests/_support
+    envs: tests/_envs
+modules:
+    - Asserts
+bootstrap: bootstrap.php
+settings:
+    colors: true
+    memory_limit: 1024M
+include:
+    - tests/cases/*

composer.json

@@ -22,10 +22,30 @@
         "codeception/lib-innerbrowser": "^1.0",
         "codeception/codeception": "^4.0"
     },
+    "require-dev": {
+        "yiisoft/yii2": "dev-master",
+        "yiisoft/yii2-app-advanced": "dev-master",
+        "codeception/verify": "<2",
+        "codemix/yii2-localeurls": "^1.7",
+        "codeception/module-asserts": "^1.3",
+        "codeception/module-filesystem": "^1.0"
+    },
     "autoload":{
         "classmap": ["src/"]
     },
+    "autoload-dev": {
+        "classmap": [
+            "vendor/yiisoft/yii2/Yii.php",
+            "tests/cases"
+        ]
+    },
     "config": {
         "classmap-authoritative": true
-    }
+    },
+    "repositories": [
+        {
+            "type": "composer",
+            "url": "https://asset-packagist.org"
+        }
+    ]
 }

tests/bootstrap.php

@@ -0,0 +1,10 @@
+<?php
+defined('YII_DEBUG') || define('YII_DEBUG', true);
+defined('YII_ENV') || define('YII_ENV', 'test');
+
+Yii::$container = new \yii\di\Container();
+
+$link = __DIR__ . '/../vendor/yiisoft/yii2-app-advanced/vendor';
+if (!file_exists($link) && !symlink(__DIR__ . '/../vendor', $link)) {
+    die('failed to create symlink');
+}

tests/cases/closeConnections/codeception.yml

@@ -0,0 +1,12 @@
+paths:
+    tests: .
+    log: ../../_output
+    data: _data
+    support: ../../_support
+namespace: tests\
+modules:
+  config:
+    Yii2:
+      configFile: config.php
+      transaction: false
+      cleanup: true

tests/cases/closeConnections/config.php

@@ -0,0 +1,12 @@
+<?php
+return [
+    'id' => 'Simple',
+    'basePath' => __DIR__,
+
+    'components' => [
+        'db' => [
+            'class' => yii\db\Connection::class,
+            'dsn' => 'sqlite:' . \tests\helpers\SqlliteHelper::getTmpFile(),
+        ],
+    ],
+];

tests/cases/closeConnections/fixtures/EmptyFixture.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace tests\fixtures;
+
+use yii\test\DbFixture;
+
+class EmptyFixture extends DbFixture
+{
+    public function load()
+    {
+    }
+
+    public function unload()
+    {
+    }
+}

tests/cases/closeConnections/functional.suite.yml

@@ -0,0 +1,5 @@
+actor: FunctionalTester
+modules:
+  enabled:
+    - Yii2
+    - Asserts

tests/cases/closeConnections/functional/FixturesCest.php

@@ -0,0 +1,35 @@
+<?php
+
+namespace tests\closeConnections;
+
+use Codeception\Example;
+use tests\fixtures\EmptyFixture;
+use tests\FunctionalTester;
+use tests\helpers\SqlliteHelper;
+
+class FixturesCest
+{
+    public function _fixtures()
+    {
+        return [
+            [
+                'class' => EmptyFixture::class,
+            ],
+        ];
+    }
+
+    protected function numberProvider()
+    {
+        return array_pad([], 5, ['count' => 0]);
+    }
+
+    /**
+     * @param FunctionalTester $I
+     * @dataProvider numberProvider
+     */
+    public function NoConnections(FunctionalTester $I, Example $example)
+    {
+        $I->assertEquals(SqlliteHelper::connectionCount(), $example['count']);
+    }
+
+}

tests/cases/closeConnections/functional/FixturesInBeforeCest.php

@@ -0,0 +1,35 @@
+<?php
+
+namespace tests\closeConnections;
+
+use Codeception\Example;
+use tests\fixtures\EmptyFixture;
+use tests\FunctionalTester;
+use tests\helpers\SqlliteHelper;
+
+class FixturesInBeforeCest
+{
+    public function _before(FunctionalTester $I)
+    {
+        $I->haveFixtures([
+            [
+                'class' => EmptyFixture::class,
+            ],
+        ]);
+    }
+
+    protected function numberProvider()
+    {
+        return array_pad([], 5, ['count' => 1]);
+    }
+
+    /**
+     * @param FunctionalTester $I
+     * @dataProvider numberProvider
+     */
+    public function NoConnections(FunctionalTester $I, Example $example)
+    {
+        $I->assertEquals(SqlliteHelper::connectionCount(), $example['count']);
+    }
+
+}

tests/cases/closeConnections/functional/NoFixturesCest.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace tests\closeConnections;
+
+use Codeception\Example;
+use tests\FunctionalTester;
+use tests\helpers\SqlliteHelper;
+
+class NoFixturesCest
+{
+
+    protected function numberProvider()
+    {
+        return array_pad([], 5, ['count' => 0]);
+    }
+
+    /**
+     * @param FunctionalTester $I
+     * @dataProvider numberProvider
+     */
+    public function NoConnections(FunctionalTester $I, Example $example)
+    {
+        $I->assertEquals(SqlliteHelper::connectionCount(), $example['count']);
+    }
+}

tests/cases/closeConnections/helpers/SqlliteHelper.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace tests\helpers;
+
+class SqlliteHelper
+{
+    protected static $temp_name;
+
+    public static function getTmpFile()
+    {
+        if (empty(self::$temp_name)) {
+            self::$temp_name = tempnam(null, '/file0');
+        }
+        return self::$temp_name;
+    }
+
+    public static function connectionCount()
+    {
+        $path = self::$temp_name;
+        $count = shell_exec("lsof -w {$path} | grep {$path} | wc -l");
+        return (int)$count;
+    }
+
+    public static function debug()
+    {
+        $path = self::$temp_name;
+        $cmd = "lsof -w {$path}";
+        codecept_debug("Executing : $cmd");
+        codecept_debug(shell_exec($cmd));
+    }
+
+}

tests/cases/closeConnectionsNoCleanup/codeception.yml

@@ -0,0 +1,12 @@
+paths:
+    tests: .
+    log: ../../_output
+    data: _data
+    support: ../../_support
+namespace: tests\
+modules:
+  config:
+    Yii2:
+      configFile: config.php
+      transaction: false
+      cleanup: false

tests/cases/closeConnectionsNoCleanup/config.php

@@ -0,0 +1,12 @@
+<?php
+return [
+    'id' => 'Simple',
+    'basePath' => __DIR__,
+
+    'components' => [
+        'db' => [
+            'class' => yii\db\Connection::class,
+            'dsn' => 'sqlite:' . \tests\helpers\SqlliteHelper::getTmpFile(),
+        ],
+    ],
+];

tests/cases/closeConnectionsNoCleanup/functional.suite.yml

@@ -0,0 +1,5 @@
+actor: FunctionalTester
+modules:
+  enabled:
+    - Yii2
+    - Asserts

tests/cases/closeConnectionsNoCleanup/functional/FixturesCest.php

@@ -0,0 +1,38 @@
+<?php
+
+namespace tests\closeConnectionsNoCleanup;
+
+use tests\FunctionalTester;
+use tests\fixtures\EmptyFixture;
+use tests\helpers\SqlliteHelper;
+
+class FixturesCest
+{
+    public function _fixtures()
+    {
+        return [
+            [
+                'class' => EmptyFixture::class,
+            ],
+        ];
+    }
+
+    public function NoConnections1(FunctionalTester $I)
+    {
+        $count = SqlliteHelper::connectionCount();
+        $I->assertEquals(0, $count);
+    }
+
+    public function NoConnections2(FunctionalTester $I)
+    {
+        $count = SqlliteHelper::connectionCount();
+        $I->assertEquals(0, $count);
+    }
+
+    public function NoConnections3(FunctionalTester $I)
+    {
+        $count = SqlliteHelper::connectionCount();
+        $I->assertEquals(0, $count);
+    }
+
+}

tests/cases/closeConnectionsNoCleanup/functional/FixturesInBeforeCest.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace tests\closeConnectionsNoCleanup;
+
+use tests\FunctionalTester;
+use tests\fixtures\EmptyFixture;
+use tests\helpers\SqlliteHelper;
+
+class FixturesInBeforeCest
+{
+    public function _before(FunctionalTester $I)
+    {
+        $I->haveFixtures([
+            [
+                'class' => EmptyFixture::class,
+            ],
+        ]);
+    }
+
+    public function OnlyOneConnection1(FunctionalTester $I)
+    {
+        $count = SqlliteHelper::connectionCount();
+        $I->assertEquals(1, $count);
+    }
+
+    public function OnlyOneConnection2(FunctionalTester $I)
+    {
+        $count = SqlliteHelper::connectionCount();
+        $I->assertEquals(1, $count);
+    }
+
+    public function OnlyOneConnection3(FunctionalTester $I)
+    {
+        $count = SqlliteHelper::connectionCount();
+        $I->assertEquals(1, $count);
+    }
+}