Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge tests repo #56

Merged
merged 12 commits into from Nov 26, 2021
Merged

Merge tests repo #56

merged 12 commits into from Nov 26, 2021

Conversation

DBX12
Copy link
Contributor

@DBX12 DBX12 commented Oct 26, 2021

I moved the tests from the separate directory to this repository so they can be cloned altogether as discussed here. (Ok, discussion is a strong word, it was talked about in two comments :D )

I can squash the commits if you want (or you do a squash merge), I kept all of them to make retracing my steps easier.

I hope I got the github workflow right, that was my first time working with them. And as always, I would greatly appreciate the hacktoberfest-accepted label on the PR :)

@DBX12
Copy link
Contributor Author

DBX12 commented Oct 26, 2021

As written above, I'm not "fluent" in github workflows. As far as I can judge this is because fxp/composer-asset-plugin is missing, would adding composer global require "fxp/composer-asset-plugin:~1.3" in the Install dependencies step fix the issue?

@samdark
Copy link
Collaborator

samdark commented Oct 26, 2021

fxp/composer-asset-plugin should not be required for current Yii 2 apps.

@samdark
Copy link
Collaborator

samdark commented Oct 26, 2021

https://github.com/yiisoft/yii2-app-advanced/blob/master/composer.json#L39 - this should help.

@DBX12
Copy link
Contributor Author

DBX12 commented Oct 26, 2021

Copying the .gitignore contents first and thinking about it second was not the smartest move 😅

tests/bootstrap.php Outdated Show resolved Hide resolved
@samdark samdark requested a review from SamMousa October 26, 2021 17:50
@samdark samdark merged commit 3fecea9 into Codeception:master Nov 26, 2021
@samdark
Copy link
Collaborator

samdark commented Nov 26, 2021

👍

@DBX12 DBX12 deleted the merge-tests-repo branch November 26, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants