Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Create automatic development builds of NewCaw #46

Merged
merged 7 commits into from
Jul 25, 2022
Merged

Create automatic development builds of NewCaw #46

merged 7 commits into from
Jul 25, 2022

Conversation

CodedOre
Copy link
Owner

This adds an workflow file for GitHub Actions to automatically build and test when there is a new commit or pull request on the repository.

@CodedOre
Copy link
Owner Author

So it seems like GitHub don't want to run my actions...
The question is: Why?

@CodedOre
Copy link
Owner Author

Well, now it's technically works...
However, there's enough that let's me say that I want to rework this...

  1. The job matrix makes it easy to test it with certain platforms enabled or disabled, but the resulting job names aren't exactly good.
  2. As of now I run the tests from the flatpak-builder action. That works, but when a test fails, the job is considered to fail as a whole, and you don't get a dev build.

And it seems I need to look into a few tests again...

@CodedOre CodedOre marked this pull request as draft July 15, 2022 21:49
@IBBoard
Copy link
Contributor

IBBoard commented Jul 17, 2022

With the job names, there's apparently a setting called name that lets you set a pattern 🙂 https://futurestud.io/tutorials/github-actions-customize-the-job-name

With the testing, can you not just do the build and the test separately? It looks like it should just need the run-tests setting removing and then ninja test in a separate step.

@CodedOre CodedOre force-pushed the actions branch 2 times, most recently from cec53c8 to e27971a Compare July 18, 2022 13:38
@CodedOre CodedOre marked this pull request as ready for review July 18, 2022 13:49
@CodedOre
Copy link
Owner Author

Made some changes to it and I think I would leave it as is.

After rethinking I have to say that it's easier to fix the issues of the tests than to move the test step out of flatpak-builder.

The only problem now is that the appdata-checker fails to check the screenshot file, but only in the GitHub Action, locally it works fine.

@IBBoard
Copy link
Contributor

IBBoard commented Jul 18, 2022

GitHub actions have working directories. It's not something as simple as that, is it? I've had things seem to work locally but fail on GitHub because I didn't track which ones were in a directory and which ones were a level higher up 🙂

Update with newly pulled JSON from the API, as well as some updates to the checks
as we escape the final text now, so we need to reflect that in the test check.
In order for our CI to not fail the appdata check test, we now add a fake
release and a first screenshot into the appdata.
Let us automatically build an Flatpak of the development build.
@CodedOre
Copy link
Owner Author

I think that the issue with appstream-utils has to do with the flatpak-builder-action, or the image it's using.
So, this has to wait until flatpak/flatpak-github-actions#87 is resolved.

This includes:
- Using `secret-opts` to include the OAuth Key more securely
- Have distinct artifact names for each job
- Use an one-dimensional build option for platform selection
appstream-util seems to have problems with it
This test has blocked the action for some time but is not a necessity,
so let's disable it until the issues are fully resolved.
@CodedOre
Copy link
Owner Author

Since our issue with the appdata test will not be resolved until the fix will make it's way into an release inside the Gnome SDK, I've decided to disable the test for now, as the rest now works as excepted.

Merging it.

@CodedOre CodedOre merged commit 158cd09 into main Jul 25, 2022
@CodedOre CodedOre deleted the actions branch July 25, 2022 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants