Skip to content

Commit

Permalink
👷 add codeclimate config
Browse files Browse the repository at this point in the history
* note: don't care about dangling commas right now
  we shouldn't have dangling commas (http://eslint.org/docs/rules/comma-dangle),
  if we want to support IE 8, but we aren't trying to support IE 8

* note: we also tell codeclimate to use more modern eslint

* note: we ignore a number of vendor files

* removed csslintrc option csslint didn't know about,
  I think this was put there by codeclimate - maybe they have nonstandard csslint?
  "---exclude-exts=.min.css" in .csslintrc

* note: approve qualified-headings
  qualified-headings are OK because we're using html5, so
  .foo h1, and .bar h1 are reasonable.

* ignore minified css files
  we should only be testing original source files

* includes stylelint engine

* lower duplication warning levels - settings were too strict
  codeclimate was catching places where two kind-of similar lines were repeated in one other place,
  and the code seemed fine (short enough and duplication of strings, stuff like that).
  • Loading branch information
techieshark committed Nov 28, 2016
1 parent 527315a commit e0b6f6d
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 0 deletions.
30 changes: 30 additions & 0 deletions .codeclimate.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
---
engines:
csslint:
enabled: true
duplication:
enabled: true
config:
languages:
javascript:
mass_threshold: 42
count_threshold: 3
eslint:
enabled: true
channel: eslint-3
fixme:
enabled: true
stylelint:
enabled: true
channel: beta
ratings:
paths:
- "**.css"
- "**.inc"
- "**.js"
- "**.jsx"
- "**.module"
exclude_paths:
- "**/vendor/**/*"
- "**/*.min.css"
- js/vendor/*
1 change: 1 addition & 0 deletions .csslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
--ignore=adjoining-classes,box-model,ids,order-alphabetical,unqualified-attributes,qualified-headings
2 changes: 2 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
**/*{.,-}min.js
js/vendor/*

0 comments on commit e0b6f6d

Please sign in to comment.