Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H3 typography options apply to H2 headings on blog/search pages #4067

Open
rodica-andronache opened this issue Aug 10, 2023 · 2 comments
Open
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.

Comments

@rodica-andronache
Copy link
Contributor

Description

Coming from this ticket, I've noticed that on the blog page we have H2 headings for the titles, but H3 typography options(except font size) apply there, which is confusing. Not sure if it's a bug or not. Saw this as well #3107

Step-by-step reproduction instructions

  1. Install Neve and create a post
  2. check the post on the blog page -> the title is H2
  3. try to change the typography(except font size) by going to Customize > Typography > Headings > H2 -> it's not working
  4. try to change the typography(except font size) by going to Customize > Typography > Headings > H3 -> it's working

Screenshots, screen recording, code snippet or Help Scout ticket

Annotation-Annotation on 2023-08-10 at 15-29-40 png

Environment info

No response

Is the issue you are reporting a regression

No

@rodica-andronache rodica-andronache added the bug This label could be used to identify issues that are caused by a defect in the product. label Aug 10, 2023
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Aug 10, 2023
@cristian-ungureanu
Copy link
Contributor

I am not sure how to solve this one. Here's what happened:

Now comes the tricky part. If we fix this to work as it should, the font size of the headings will suddenly change on the user's sites if they didn't actually set the typography for the blog.

In summary, the "blog-entry-title" class is controlled from 2 places:

  1. From its own settings
  2. From the general Headings control ( but H3 instead of H2 ) if its own settings aren't set

If we fix the issue, some people that don't have typography for blogs in place will experience some unwanted changes. If we don't fix the issue, the title can still be changed.

An idea is to apply the fix for new users only but we might overcomplicate things.

Let me know what you think.

@HardeepAsrani
Copy link
Member

Thank you @cristian-ungureanu, in this case we don't need to take any action here and we can put this in backlog. Thanks for sharing the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer.
Projects
None yet
Development

No branches or pull requests

4 participants