-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connected user list #40
Conversation
Amazing work @santakadev 🙌🙌🙌 Some observations that you may already have noticed. I've recorded a video in order to illustrate the issues properly. These issues wouldn't block the merge of this PR, but just in order to take them into account for further PRs (you can create issues for them with the information you could provide): AnonymousWhen a second user opens the same session but before he introduces its nickname, it appears in the However, I wouldn't vote for changing this behaviour 😬. Instead, I would go for leaving the user land right in the editor of an existing session and letting him edit his preferences afterwards. That is, not asking his nickname before joining the session. The main reason would be to reduce the friction with the user to the bare minimum while joining a session. This is something similar to what http://zoom.us does while joining an existing conference session If we go for this approach, it'll be definitely useful to list new session joiners as Anonymous until they set their nickname 🙂 DelayIt has some delay in between making the In fact, if you closely look at the 13th second of the video, you'll see how the 🤟 |
Thanks @JavierCane! About the nickname, I'll create an issue in order to improve de UX for setting its nickname. I'll take a look at how zoom.us works. About the nickname disappearing, I've realized that what is happening is that the WebRTC connection is being lost, and for that reason the name disappears for some seconds. I'll try to fix this bug before merging into master. |
Closes #7 and #37
Changes
Architecture changes