Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected user list #40

Merged
merged 31 commits into from
Jun 13, 2019
Merged

Connected user list #40

merged 31 commits into from
Jun 13, 2019

Conversation

santakadev
Copy link
Contributor

Closes #7 and #37

Changes

  • Added user list component
  • Added right panel/menu to open/close user list.

Architecture changes

@santakadev santakadev added the feature New feature or request label Jun 6, 2019
@santakadev santakadev added this to the 1.1 milestone Jun 6, 2019
@santakadev santakadev self-assigned this Jun 6, 2019
@santakadev santakadev added this to In progress in P2P Editor via automation Jun 6, 2019
@JavierCane
Copy link
Member

Amazing work @santakadev 🙌🙌🙌

Some observations that you may already have noticed. I've recorded a video in order to illustrate the issues properly. These issues wouldn't block the merge of this PR, but just in order to take them into account for further PRs (you can create issues for them with the information you could provide):

Anonymous

When a second user opens the same session but before he introduces its nickname, it appears in the Users list as Anonymous. This could be confusing for the users already in the session because they could think that someone has joined and can actually see the contents of it (something not true yet).

However, I wouldn't vote for changing this behaviour 😬. Instead, I would go for leaving the user land right in the editor of an existing session and letting him edit his preferences afterwards. That is, not asking his nickname before joining the session. The main reason would be to reduce the friction with the user to the bare minimum while joining a session. This is something similar to what http://zoom.us does while joining an existing conference session

If we go for this approach, it'll be definitely useful to list new session joiners as Anonymous until they set their nickname 🙂

Delay

It has some delay in between making the Anonymous user disappear and showing up the new nickname when the user specifies its nickname. It isn't something critical, but I don't know if we could easily make this operation atomic allowing to have a real time replacement instead of making it disappear during some seconds.

In fact, if you closely look at the 13th second of the video, you'll see how the Anonymous text is firstly replaced by the new nickname guest and after that, it disappear for ~10 seconds.

🤟

P2P Editor automation moved this from In progress to Reviewer approved Jun 12, 2019
@santakadev
Copy link
Contributor Author

Thanks @JavierCane!

About the nickname, I'll create an issue in order to improve de UX for setting its nickname. I'll take a look at how zoom.us works.

About the nickname disappearing, I've realized that what is happening is that the WebRTC connection is being lost, and for that reason the name disappears for some seconds. I'll try to fix this bug before merging into master.

@santakadev santakadev merged commit f0abeb3 into master Jun 13, 2019
P2P Editor automation moved this from Reviewer approved to Done Jun 13, 2019
@santakadev santakadev deleted the connected-user-list branch June 13, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
P2P Editor
  
Done
Development

Successfully merging this pull request may close these issues.

Connected users list
2 participants